bellemare commented on pull request #139:
URL: https://github.com/apache/atlas/pull/139#issuecomment-860728403


   >     * adding a field for 'key' in HookNotification and EntityNotification 
might be a simpler/smaller change. I suggest to consider this  approach.
   
   I'm trying this now, but it doesn't seem like it works conceptually.
   
   For instance, it seems that `HookNotification` is extended by 
`EntityCreateRequestV2`. This extension, however, seems to pack in multiple 
entities via `AtlasEntitiesWithExtInfo`, meaning that there is no single key 
that `HookNotification` can use.
   
   I think I need some help conceptually here: Is `HookNotification` and 
`EntityNotification` supposed to be a bundle of an arbitrary number of 
entities? I was originally under the impression that there were meant to be 1:1 
(eg: one EntityNotification per entity). 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to