----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73370/#review223142 -----------------------------------------------------------
Ship it! Ship It! - Ashutosh Mestry On June 14, 2021, 2:21 p.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73370/ > ----------------------------------------------------------- > > (Updated June 14, 2021, 2:21 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4300 > https://issues.apache.org/jira/browse/ATLAS-4300 > > > Repository: atlas > > > Description > ------- > > **Problem:** Advanced Search support Searching entities by classification > Ex. Table isA Dimension > > But user cannot search entities by classification attributes > Ex. To search entities which has classification Dimension and Dimension.attr > = value > > **Improvement:** User will be able to search entities through classification > attributes too. > > **Example query:** "From Table where name = 'sales_fact' and Dimension.attr = > 'value' " > > > Diffs > ----- > > docs/src/documents/Search/SearchAdvanced.md 45e63675a > repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 80250fb96 > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > cff7afffc > repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java > d2906ea40 > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java > eb3c349f6 > repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java > 4091fe982 > repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 > 4bdf479f1 > repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java > 04f602c0f > repository/src/test/java/org/apache/atlas/BasicTestSetup.java a821b2549 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 3404dc6e2 > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 6220c23b9 > > > Diff: https://reviews.apache.org/r/73370/diff/3/ > > > Testing > ------- > > Unit test cases added > Precommit : > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/659/ > > > Thanks, > > Pinal Shah > >
