-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73416/#review223143
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasAbstractDefStoreV2.java
Line 117 (original), 117 (patched)
<https://reviews.apache.org/r/73416/#comment312254>

    I don't think this condition will work. It should be:
    if (!allowReservedKeywords && AtlasDSL.Parser.isKeyword(attrDef.getName()) 
|| isInternalAttributeName(attrDef.getName())


- Ashutosh Mestry


On June 14, 2021, 1:57 p.m., Mandar Ambawane wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73416/
> -----------------------------------------------------------
> 
> (Updated June 14, 2021, 1:57 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4336
>     https://issues.apache.org/jira/browse/ATLAS-4336
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Currently type can be updated with an attribute whose name starts with "__" 
> like __guid.
> 
> This gets mixed up with system attributes.
> 
> Hence attribute names should not be allowed to be started with double 
> underscore or following attribute names (system attribute names) should be 
> restricted when a type is created or updated :
> 
> __classificationNames
> __modifiedBy
> __createdBy
> __state
> __typeName
> __modificationTimestamp
> __propagatedClassificationNames
> __customAttributes
> __isIncomplete
> __guid
> __timestamp
> __labels
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasAbstractDefStoreV2.java
>  3dab120 
> 
> 
> Diff: https://reviews.apache.org/r/73416/diff/2/
> 
> 
> Testing
> -------
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/651/consoleFull
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Reply via email to