----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73549/#review223399 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java Line 329 (original), 330 (patched) <https://reviews.apache.org/r/73549/#comment312470> 'nto be' -> 'not be' repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java Line 503 (original), 487 (patched) <https://reviews.apache.org/r/73549/#comment312471> Should we still keep these two unused functions - findByTypeAndPropertyName and findBySuperTypeAndPropertyName as we have new ones. - Sidharth Mishra On Aug. 25, 2021, 9:48 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73549/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2021, 9:48 p.m.) > > > Review request for atlas, Ashutosh Mestry, Disha Talreja, Madhan Neethiraj, > Radhika Kundam, and Sidharth Mishra. > > > Bugs: ATLAS-4403 > https://issues.apache.org/jira/browse/ATLAS-4403 > > > Repository: atlas > > > Description > ------- > > When a entity type has multiple unique attributes defined: > > unique_attr1 > unique_attr2 > During creation of entity, we check if entity with unique attributes is > already present and return/update them. The current logic check if entity is > present - one unique attribute at a time, if present will return immediately. > > We should improve the lookup logic to look for entity with all unique > attributes specified and not just return on the first unique attribute value. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > e73f084b8 > > > Diff: https://reviews.apache.org/r/73549/diff/3/ > > > Testing > ------- > > Pre-commit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/822/consoleFull > (SUCCESS) > > > Thanks, > > Sarath Subramanian > >
