> On Aug. 25, 2021, 10:18 p.m., Sarath Subramanian wrote: > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/S3V2Preprocessor.java > > Lines 66 (patched) > > <https://reviews.apache.org/r/73544/diff/1/?file=2252253#file2252253line66> > > > > consider also including the 'name' attribute from aws_s3_v2_directory > > type in this check: > > > > && objectPrefix.contains(name) > > > > qualifiedName : > > s3a://my_bucket_1/datalake/warehouse/tablespace/external/hive/employee.csv/@cm > > objectPrefix : > > /datalake/warehouse/tablespace/external/hive/employee.csv/ > > name : employee.csv
We can't add name. Consider one example where location is: qualifiedName : s3a://my_bucket_1/temp/temp/temp@cm objectPrefix : /temp/temp/temp/ name : temp Even current check was not enough for this. So I added check for schema + bucket + objectPrefix + "@" - Sidharth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73544/#review223398 ----------------------------------------------------------- On Aug. 25, 2021, 11:39 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73544/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2021, 11:39 p.m.) > > > Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and > Sarath Subramanian. > > > Bugs: ATLAS-4400 > https://issues.apache.org/jira/browse/ATLAS-4400 > > > Repository: atlas > > > Description > ------- > > ATLAS-4400: Fixed Hook and Atlas Preprocessor to handle S3 V2 directory > objectPrefix Issue with Atlas Server and Hook versions mismatch > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java > a9f2e5092 > common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java > 6bf5d5779 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 5643af95c > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java > 7f0cafe86 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java > 59f6440d5 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/S3V2Preprocessor.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/73544/diff/1/ > > > Testing > ------- > > Manually tested the Newer Atlas with old Hook and vice versa. Precommit - > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/824/ > > > Thanks, > > Sidharth Mishra > >
