----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73528/#review223422 -----------------------------------------------------------
common/src/main/java/org/apache/atlas/utils/OnAtlasPropertyCondition.java Line 40 (original), 41 (patched) <https://reviews.apache.org/r/73528/#comment312492> Can you please check type before cast. webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java Lines 238 (patched) <https://reviews.apache.org/r/73528/#comment312493> Does this change the value returned. It would be worthwhile to add a UT verifying this before and after the version change. - Ashutosh Mestry On Aug. 24, 2021, 7:05 a.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73528/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2021, 7:05 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4377 > https://issues.apache.org/jira/browse/ATLAS-4377 > > > Repository: atlas > > > Description > ------- > > Atlas is pulling in Spring security 4.2.17.RELEASE upgrade to 5.4.4, 5.3.8, > or 5.2.9 > Upgrading spring-security version to 5.5.1 this is the latest > Upgrading spring-core version to 5.3.8 current version 4.3.29.RELEASE > > > Diffs > ----- > > addons/falcon-bridge-shim/pom.xml 02da049db > addons/falcon-bridge/pom.xml e0d2f3be7 > authorization/pom.xml 8e5a85db4 > common/src/main/java/org/apache/atlas/utils/OnAtlasPropertyCondition.java > ece6e370a > pom.xml cf0eb34a7 > repository/pom.xml bf34efee2 > repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java > 343d00d72 > test-tools/pom.xml c861ea67f > webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e16796ff6 > webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 71eca2e50 > webapp/src/main/webapp/WEB-INF/web.xml 7fb56efde > webapp/src/test/webapp/WEB-INF/web.xml 2388fbfbb > > > Diff: https://reviews.apache.org/r/73528/diff/2/ > > > Testing > ------- > > mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip > Atlas server runnning > mvn clean install -DskipTests > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/811/console > > > Thanks, > > chaitali > >
