----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73584/#review223486 -----------------------------------------------------------
Ship it! lgtm. Can you include UT/IT tests around this sorting. - Sarath Subramanian On Sept. 13, 2021, 11:38 p.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73584/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2021, 11:38 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath > Subramanian. > > > Bugs: ATLAS-4422 > https://issues.apache.org/jira/browse/ATLAS-4422 > > > Repository: atlas > > > Description > ------- > > **Improvement:** > > This will add a sorting functionality in quick search API and get the result > list in Sorted manner. > > **Note:** > > - Result will be sorted only when 'typeName' has a valid entity type name as > a value. > - Only string attribute type (not TEXT) guarantees sorted results > > **Example:** > > { "query":"sales", > "typeName":"Asset", > "sortBy":"__typeName", > "sortOrder":"ASCENDING" } > > > Diffs > ----- > > > intg/src/main/java/org/apache/atlas/model/discovery/QuickSearchParameters.java > 9e5e9778a > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 5b3b9486b > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e4c74a9d1 > > > Diff: https://reviews.apache.org/r/73584/diff/1/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Pinal Shah > >
