----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73599/#review223509 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Line 359 (original), 374 (patched) <https://reviews.apache.org/r/73599/#comment312589> I think it will be intuitive to move logoutHandler != null check to inner if condition on line #375. - Sailaja Polavarapu On Sept. 21, 2021, 6:38 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73599/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2021, 6:38 p.m.) > > > Review request for atlas, Nikhil Bonte, Nixon Rodrigues, Prasad Pawar, and > Sarath Subramanian. > > > Bugs: ATLAS-4435 > https://issues.apache.org/jira/browse/ATLAS-4435 > > > Repository: atlas > > > Description > ------- > > Please see JIRA for details. > > Additional info: > * UI pop-up dialog looks at the value passed in the response of > 'admin/session' REST endpoint. Not passing the configuration value, disables > the feature from UI (Smart!). > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java fa519ef5a > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > b8d21b9bb > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > baa040f4c > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java > 1b1a80826 > > > Diff: https://reviews.apache.org/r/73599/diff/1/ > > > Testing > ------- > > Manual testing: > * Verified against Knox SSO enabled cluster. > * User-name password enabled cluster. > > > Thanks, > > Ashutosh Mestry > >
