----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73616/#review223541 -----------------------------------------------------------
Fix it, then Ship it! please add UT/IT test coverage. addons/hive-bridge/src/bin/import-hive.sh Line 159 (original), 159 (patched) <https://reviews.apache.org/r/73616/#comment312609> "Meta Data" => "metadata" - Sarath Subramanian On Sept. 27, 2021, 10:29 p.m., Disha Talreja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73616/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2021, 10:29 p.m.) > > > Review request for atlas, Ashutosh Mestry and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > Even if a non-existent file name/ database name/ table name is passed to the > import-hive script, hive meta data gets imported successfully. This gives the > user an impression that the import is successful while nothing has actually > happened. With this patch, the program gets terminated for any incorrect > argument passed and the issue is logged in the log file. > > > Diffs > ----- > > addons/hive-bridge/src/bin/import-hive.sh fde486f28 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 08471b480 > > > Diff: https://reviews.apache.org/r/73616/diff/1/ > > > Testing > ------- > > Patched in a cluster. > > > Thanks, > > Disha Talreja > >
