-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73595/
-----------------------------------------------------------

(Updated Oct. 4, 2021, 3:44 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, and 
Sarath Subramanian.


Bugs: ATLAS-4428
    https://issues.apache.org/jira/browse/ATLAS-4428


Repository: atlas


Description
-------

Atlas hook messages doesn't specify the source information of the messages 
coming i.e. which hook source - HiveServer2, HiveMetastore, Impala, Spark, 
HBase, Kafka.

Each hook message already captures, the msgSourceIP, msgCreatedBy and 
msgCreationTime info. In addition to these, we should capture the msgSource 
information as well.

When messages come from different hook versions, Atlas server should be aware 
of the version of different hook messages to process the message based on the 
hook version.


Diffs (updated)
-----

  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 
8c09d3394 
  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 0ab06f2c5 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
3cc7b3bc6 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveMetastoreHookImpl.java
 6a492c214 
  
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java
 10ae08f6d 
  addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
4785960a7 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 779c5cb20 
  common/src/main/java/org/apache/atlas/repository/Constants.java aea0c1311 
  intg/pom.xml 691cdf0a3 
  
intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationBaseMessage.java
 ff45d5713 
  
intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationMessage.java
 5869910cb 
  intg/src/main/java/org/apache/atlas/model/notification/MessageSource.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 9162ac144 
  
notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java
 c45a1da95 
  
notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
 3d8d9cc0a 
  
notification/src/main/java/org/apache/atlas/notification/spool/AtlasFileSpool.java
 0c92c300e 
  notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java 1ae7c278c 
  
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java
 8078a6ceb 
  
notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationDeserializerTest.java
 13eafb6b1 
  
notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationDeserializerTest.java
 d04817024 


Diff: https://reviews.apache.org/r/73595/diff/5/

Changes: https://reviews.apache.org/r/73595/diff/4-5/


Testing
-------

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
testcases running successfully


Thanks,

chaitali

Reply via email to