> On Oct. 18, 2021, 10:44 p.m., Sarath Subramanian wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > > Line 131 (original), 150 (patched) > > <https://reviews.apache.org/r/73586/diff/4/?file=2254089#file2254089line153> > > > > instead of throwing ParseException, should we set exitCode = > > EXIT_CODE_INVALID_ARG? > > > > Also add a lOG.ERROR about the details.
As we handle at catch block and print the LOG.error msg and set exit code accordingly. > On Oct. 18, 2021, 10:44 p.m., Sarath Subramanian wrote: > > addons/hive-bridge/src/bin/import-hive.sh > > Line 160 (original), 168 (patched) > > <https://reviews.apache.org/r/73586/diff/6/?file=2254123#file2254123line168> > > > > nit: this overrides previous change. Consider reverting and keep the > > original echo msg. This to display the error msg only when the import is either successful or failed. Other than that like invalid arg prints different appropriate msg. > On Oct. 18, 2021, 10:44 p.m., Sarath Subramanian wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeV2.java > > Lines 163 (patched) > > <https://reviews.apache.org/r/73586/diff/6/?file=2254125#file2254125line163> > > > > line 163-169 (4 methods) deals with error checking and initializing. > > Consider encapsulating to an init() method to hide the specifics. Put the initialization of zip stream into one as we need the try finally block for this (keeping the validateOutputFilePath separate) - Sidharth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73586/#review223618 ----------------------------------------------------------- On Oct. 18, 2021, 6:18 a.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73586/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2021, 6:18 a.m.) > > > Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and > Sarath Subramanian. > > > Bugs: ATLAS-4424 > https://issues.apache.org/jira/browse/ATLAS-4424 > > > Repository: atlas > > > Description > ------- > > ATLAS-4424: Enhanced the Import hive utility to create export zip files and > run bulk import > > > Diffs > ----- > > addons/hive-bridge/src/bin/import-hive.sh c3539377f > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > c361ac69a > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeV2.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java > 2c1870444 > > intg/src/main/java/org/apache/atlas/model/migration/MigrationImportStatus.java > 3430fdae8 > > repository/src/main/java/org/apache/atlas/repository/migration/DataMigrationStatusService.java > a22c68790 > > repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java > bfb114814 > > repository/src/test/java/org/apache/atlas/repository/impexp/DataMigrationStatusServiceTest.java > f1dc990e8 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 135b94b36 > > > Diff: https://reviews.apache.org/r/73586/diff/6/ > > > Testing > ------- > > Manually tested the new zip file creation and bulk import to atlas > > > Thanks, > > Sidharth Mishra > >
