----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73669/#review223679 -----------------------------------------------------------
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java Lines 184 (patched) <https://reviews.apache.org/r/73669/#comment312780> Instead of killing the process, why not attempt to use next available port. notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java Lines 194 (patched) <https://reviews.apache.org/r/73669/#comment312779> This won't work on Windows. notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java Lines 207 (patched) <https://reviews.apache.org/r/73669/#comment312781> Call this in finally pom.xml Line 1688 (original), 1680 (patched) <https://reviews.apache.org/r/73669/#comment312778> What is the reason for downgrading this? repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java Line 70 (original), 72 (patched) <https://reviews.apache.org/r/73669/#comment312782> If possible, package this in a separate patch. repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java Lines 185 (patched) <https://reviews.apache.org/r/73669/#comment312776> Change: Index Health Monitor: Shutdown: Starting... repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java Lines 195 (patched) <https://reviews.apache.org/r/73669/#comment312777> Change: Index Health Monitor: Shutdown: Done! Add this to finally block. - Ashutosh Mestry On Oct. 28, 2021, 5:08 a.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73669/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2021, 5:08 a.m.) > > > Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and > Sarath Subramanian. > > > Bugs: ATLAS-4462 > https://issues.apache.org/jira/browse/ATLAS-4462 > > > Repository: atlas > > > Description > ------- > > ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to > true to stop jetty at end of post integration, Added retry logic for Kafka > start having port bind issue, Fixed Infinite loop for Index Recovery Service > > > Diffs > ----- > > addons/falcon-bridge/pom.xml 9d56fd8d3 > addons/hbase-bridge/pom.xml 151a62a77 > addons/hive-bridge/pom.xml f62140918 > addons/impala-bridge/pom.xml 87650e1da > addons/kafka-bridge/pom.xml 2ac19fd20 > addons/sqoop-bridge/pom.xml 03861df84 > addons/storm-bridge/pom.xml 6bfe15b5b > common/pom.xml ebf8ea5ae > graphdb/janus/pom.xml f38c4e9a3 > notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java > 19717fb2b > pom.xml 84630e76b > > repository/src/main/java/org/apache/atlas/repository/graph/IndexRecoveryService.java > 2f1161067 > test-tools/pom.xml 59c7a9dbf > webapp/pom.xml 443559c8d > > > Diff: https://reviews.apache.org/r/73669/diff/1/ > > > Testing > ------- > > Manually tested the Infinite loop issue at Index Recovery Service, Kafka > retry logic for kafka start. Along with this I ran the local tests which > passed. > > > Thanks, > > Sidharth Mishra > >
