----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74011/#review224484 -----------------------------------------------------------
Ship it! Ship It! - Prasad Pawar On June 7, 2022, 5:20 a.m., Farhan Khan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74011/ > ----------------------------------------------------------- > > (Updated June 7, 2022, 5:20 a.m.) > > > Review request for atlas, Jayendra Parab and Prasad Pawar. > > > Bugs: ATLAS-4583 > https://issues.apache.org/jira/browse/ATLAS-4583 > > > Repository: atlas > > > Description > ------- > > In old UI, when there is no data for classification and glossary, if the user > selects either 'tree' toggle in classification or 'category' toggle in > glossary section, and then attempts to switch UI, they get an endless loading > page with the following error message: > > viewType=tree: Unknown/invalid classification > > or > > Given instance guid viewType=category is invalid/not found > > > > Also found an issue where after creating a classification, switching from > Classic UI to new UI and then deleting the classification results in an > endless loading within the deletion dialog box. > > > Diffs > ----- > > dashboardv2/public/js/views/tag/TagLayoutView.js 38df18792 > dashboardv3/public/js/router/Router.js 701b65104 > dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js > ef53c9533 > > > Diff: https://reviews.apache.org/r/74011/diff/1/ > > > Testing > ------- > > Tested manually on both the UI for above mentioned scenario in the > description, working fine after the fix. > > > Thanks, > > Farhan Khan > >
