-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74077/
-----------------------------------------------------------
(Updated Aug. 2, 2022, 1:21 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Nixon Rodrigues.
Changes
-------
Updated diff with some refactoring and increased timeout for Kafka consumer
shutdown.
Bugs: ATLAS-4619
https://issues.apache.org/jira/browse/ATLAS-4619
Repository: atlas
Description
-------
Goal is to break the strong coupling between Atlas components and Kafka. These
dependencies include using server side libraries of Kafka (this couples the
Scala version and other non-public interfaces of Kafka). Any code using server
side libraries of Kafka should be refactored.
The webapp module uses ShutdownAbleThread from the core kafka library. With
this commit, it is changed to Thread, as the try-catch-finally block inside the
run() method should solve the issue with closing the consumer.
Diffs (updated)
-----
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
49c504f9f
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
fdfc2560d
Diff: https://reviews.apache.org/r/74077/diff/2/
Changes: https://reviews.apache.org/r/74077/diff/1-2/
Testing
-------
- Unit tests are green
- Atlas server is healthy on manually provisoned cluster
- Tested the functionality with Hive Hook, no ConcurrentModificationException
was present in the logs after stopping Atlas server.
Thanks,
Patrik Márton
