-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74109/
-----------------------------------------------------------
(Updated Sept. 21, 2022, 9:48 a.m.)
Review request for atlas, Jayendra Parab, Radhika Kundam, and Sidharth Mishra.
Changes
-------
addressed review comments
Bugs: ATLAS-4671
https://issues.apache.org/jira/browse/ATLAS-4671
Repository: atlas
Description (updated)
-------
**Issue** : Basic search has AtlasEntityHeader of each entity in the response.
AtlasEntityHeader has many attributes including classification and terms. hence
for each attribute, it will request janusgraph
**Approach** : To overcome, we can add a flag to exclude other attributes and
add only selected attributes from 'attributes' field in the response
**Working** : This improvement can be seen, if user has **entityTypes**,
**excludeHeaderAttributes=true** and **valid entity attributes (not
relationship) in 'attributes' field** , in the request payload.
**Request**: {
"excludeDeletedEntities": true,
"includeSubClassifications": true,
"includeSubTypes": true,
"includeClassificationAttributes": true,
"limit": 25,
"offset": 0,
"typeName": "hdfs_path",
"attributes": ["path", "name"],
"excludeHeaderAttributes": "true"
}
**Response**: {
"queryType": "BASIC",
"searchParameters": {
"typeName": "hdfs_path",
"excludeDeletedEntities": true,
"includeClassificationAttributes": true,
"includeSubTypes": true,
"includeSubClassifications": true,
"limit": 25,
"offset": 0,
"attributes": ["path", "name"]
},
"attributes": {
"name": ["path", "name"],
"values": [
["/data/warehouse/customer", "customer"],
["/data/warehouse/sales", "sales"]
]
},
"approximateCount": 2
}
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/discovery/QuickSearchParameters.java
79f5aae0d
intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java
78fb4a48f
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
8fbc22fa0
repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
01954d07e
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
fbc739652
Diff: https://reviews.apache.org/r/74109/diff/6/
Changes: https://reviews.apache.org/r/74109/diff/5-6/
Testing
-------
Unit testcases added
Precommit :
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1215/
Performance Readings:
Basic Search on 20K entities, limit 1000
Thanks,
Pinal Shah
