----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74133/#review224767 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java Line 315 (original), 315 (patched) <https://reviews.apache.org/r/74133/#comment313570> Can you add an comment stating default relationshipCategory is ASSOCIATION - Pinal Shah On Oct. 6, 2022, 9:42 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74133/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2022, 9:42 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Pinal Shah, Radhika Kundam, Sarath Subramanian, Sheetal Shah, and Sidharth > Mishra. > > > Bugs: ATLAS-4678 > https://issues.apache.org/jira/browse/ATLAS-4678 > > > Repository: atlas > > > Description > ------- > > When Relationship typedef is created without "relationshipCategory", the > default "relationshipCategory" provided as "ASSOCIATION". > For "relationshipCategory" "ASSOCIATION", it is required that both enddefs > should have "isContainer" value as "false". > > while creating the Relationship type, Whenever user does not provide the > "relationshipCategory" value and put one of the "isContainer" value as "true". > Because of this, Relationship type gets created with "relationshipCategory" = > "ASSOCIATION" and one of the Enddefs with "isContainer" = "true" > > When atlas service is restarted, it throws and exception for such > Relationship type. and due to this, entire TypeRegistry does not get > populated. > So even after the Atlas service comes up, user cannot see any Typedefs. > > At the time of create operation, this patch checks Relationship type which > has no "relationshipCategory", it also checks for the "isContainer" values > for both the Enddefs. > If both "isContainer" values are false, then only it sets the default > "relationshipCategory" as "ASSOCIATION" otherwise it throws an exception. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 5b1737b70 > > > Diff: https://reviews.apache.org/r/74133/diff/3/ > > > Testing > ------- > > > Thanks, > > Mandar Ambawane > >
