----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74176/#review224814 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java Line 77 (original), 77 (patched) <https://reviews.apache.org/r/74176/#comment313649> Consider clearing the RequestContext at the start of the method, before its used anywhere. - Jayendra Parab On Oct. 18, 2022, 6:45 p.m., Disha Talreja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74176/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2022, 6:45 p.m.) > > > Review request for atlas and Jayendra Parab. > > > Bugs: ATLAS-4674 > https://issues.apache.org/jira/browse/ATLAS-4674 > > > Repository: atlas > > > Description > ------- > > When we add/delete a classification from an entity, we send notification to > ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based > policy. This functionally seems to be broken and is a regression. > > > On further investigation, it is seen that the issue is caused by deferred > action for classification propagation as the right notifications are sent > when deferred action is disabled. > > > Entity details for the notification messages are fetched from the entity > cache which is not updated and lacks the new classification mapping. Hence, > this patch clears the cache so that the entity is newly mapped from it's > vertex and contains all the information. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java > 74bed571f > > > Diff: https://reviews.apache.org/r/74176/diff/1/ > > > Testing > ------- > > mvn clean -DskipTests install > mvn clean -DskipTests package -Pdist,embedded-hbase-solr > Atlas server running. > Classification add, Classification delete: Verified appropriate messages > being received on ATLAS_ENTITIES. > > > Thanks, > > Disha Talreja > >
