----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74180/#review224826 -----------------------------------------------------------
Ship it! Ship It! - Pinal Shah On Oct. 24, 2022, 8:05 a.m., Jayendra Parab wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74180/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2022, 8:05 a.m.) > > > Review request for atlas, Mandar Ambawane, Pinal Shah, Radhika Kundam, and > Sidharth Mishra. > > > Bugs: ATLAS-4691 > https://issues.apache.org/jira/browse/ATLAS-4691 > > > Repository: atlas > > > Description > ------- > > In HA setup, there is difference in response when debug metrics API > ("admin/debug/metrics") is accessed on active server and passive server. > The reason for this is debug metrics are maintained in-memory in the active > server. When "admin/debug/metrics" API call is accessed on the passive > server, the request isn't redirected to the active server like it does for > the other APIs, hence the passive node returns empty metrics. > Adding "admin/debug/metrics" to the list of adminUriNotFiltered, so that the > API call gets redirected to active server. > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java > a1d30ba87 > > > Diff: https://reviews.apache.org/r/74180/diff/1/ > > > Testing > ------- > > Tested manually on a HA setup, with this change, when the > "admin/debug/metrics" is sent to passive server, the request is redirected to > active server and correct response is returned > > > Thanks, > > Jayendra Parab > >
