----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74360/#review225297 -----------------------------------------------------------
Ship it! Ship It! - Farhan Khan On March 23, 2023, 4:47 p.m., Prasad Pawar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74360/ > ----------------------------------------------------------- > > (Updated March 23, 2023, 4:47 p.m.) > > > Review request for atlas, Farhan Khan and Jayendra Parab. > > > Bugs: https://issues.apache.org/jira/browse/ATLAS-4736 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-4736 > > > Repository: atlas > > > Description > ------- > > Bug Description: > > Create entities using the following data in POST command with the "typeName" > called "DateTimeCheck". > > typedef for "CreateTimeInText", "syncJobUpdateTimeInText" & > "syncJobCreateTimeInText" is string. > > > POST : > --data-raw ' { > "entity": { > "typeName": "DateTimeCheck", > "attributes": { > "syncJobUpdateTimeInText": "2022-12-21 09:01:36 CDT", > "UpdateTime": null, > "syncJobCreateTimeInText": "2022-12-21 09:01:36 CDT", > "syncJobCreateTime": "0", > "CreatedByUserId": "admin", > "Guid": "cc519d95-5dd5-4646-b1b3-0eae280208e6", > "description": "ENTITY_FOR_DATE_TIME_CHECK", > "syncJobUpdatedByUserId": null, > "CreateTimeInText": "2022-12-21 09:01:36 CDT", > "syncJobCreatedByUserId": null, > "syncJobType": "fullSync", > "syncJobUpdateTime": 1671649924455, > "name": "ENTITY_FOR_DATE_TIME_CHECK", > "additionalProperties": { > "authDatabase": null, > "catalogId": "cc519d95-5dd5-4646-b1b3-0eae280208e6", > "database": null, > "host": null, > "ownerId": "1000331095", > "ssl": "false", > "username": null > }, > "CreatedBy": "1000331095", > "CreateTime": 1628085696000 > } > } > }' > > > After the entity is posted, the Atlas audit tab is reporting > "CreateTimeInText", "syncJobUpdateTimeInText", and "syncJobCreateTimeInText " > created on the year of 1970. > > > Why Bug is getting produced: > The data type for "CreateTimeInText", "syncJobUpdateTimeInText", and > "syncJobCreateTimeInText "is long/string, on UI the values was getting > converted into Date Epoch format, and this was getting wrong conversion. > > Fix: > Now UI will display the values as per the data type, if data type is Date > then it will convert the value to Epoch format if needed and will get > displayed, else it will display as present in response. > > > Diffs > ----- > > dashboardv2/public/js/utils/CommonViewFunction.js b1c15507f > dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js 20eac0650 > dashboardv3/public/js/utils/CommonViewFunction.js 636bdae28 > dashboardv3/public/js/views/audit/CreateAuditTableLayoutView.js 0e2ade3fd > > > Diff: https://reviews.apache.org/r/74360/diff/1/ > > > Testing > ------- > > Manually tested, and the values are getting displayed as needed. > > > Thanks, > > Prasad Pawar > >
