----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74390/#review225424 -----------------------------------------------------------
Ship it! Ship It! - Sidharth Mishra On April 11, 2023, 4 p.m., Disha Talreja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74390/ > ----------------------------------------------------------- > > (Updated April 11, 2023, 4 p.m.) > > > Review request for atlas, Jayendra Parab, Radhika Kundam, and Sidharth Mishra. > > > Bugs: ATLAS-4739 > https://issues.apache.org/jira/browse/ATLAS-4739 > > > Repository: atlas > > > Description > ------- > > Log4j 1.x provides a class org.apache.log4j.DailyRollingFileAppender which is > no longer supported by Log4j 2.x. Hence, DailyRollingFileAppender needs to be > replaced by a custom rolling file appender supported by log4j2. > > > Diffs > ----- > > notification/src/main/java/org/apache/atlas/hook/FailedMessagesLogger.java > 5488c1c2c > > notification/src/main/java/org/apache/atlas/notification/LogConfigUtils.java > ea9c1cecc > > > Diff: https://reviews.apache.org/r/74390/diff/2/ > > > Testing > ------- > > mvn clean -DskipTests install > mvn clean -DskipTests package -Pdist,embedded-hbase-solr > Atlas server running. > PC build: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1340/ > > > Thanks, > > Disha Talreja > >
