Will do, thank you for the suggestion.
How should I update the patch file? Will uploading a new patch with the same 
name replace the old one?

Thank you!

From: Madhan Neethiraj <[email protected]> on behalf of Madhan 
Neethiraj <[email protected]>
Date: Monday, October 30, 2023 at 6:49 PM
To: Madhan Neethiraj <[email protected]>, atlas 
<[email protected]>, Dima Chechetkin 
<[email protected]>
Subject: Re: Review Request 74706: Adds a Couchbase hook for Apache Atlas
 EXTERNAL EMAIL:  Use caution when opening attachments or clicking on links




This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/74706/<https://reviews.apache.org/r/74706/> 
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/TypeGenerator.java
 (Diff revision 1) 43 public static void main(String[] args) { Generating 
typedefs dynamically and                                                        
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                                                

[Image removed by 
sender.]<https://usb.report.cybergraph.mimecast.com/alert-details/?dep=5hDRO0HGjCSqd2ytVTQH0Q%3D%3DTD1SPEsN%2Bx1R6U68u%2FPpkbhsCjIjpvz8Q1gYEV3wGq5YtyBHtuLp66TY%2F8KX7GulL6KyuLi5HtCrsG4Gn9YSSHRT8JwaY36OWkXxlJv%2BLhenKD1hjaqvw79K%2FMN%2FJiuX5qkyVN2U8DbVq5vVLEsCKdtPK97YzRtY3gwDrflI5OqNiZqqtAecbZ87iwdoZoANQU7YPfbuxAhyhjkNBuJ0kjk5A4Fd02d2OwpBEwp7wsYmaWQxdeeRWBdYPggmQu5toN5yoh4P7ysi355lzWt%2FSoSUUjo8ofvp3xKJvz5CQgfqUcskBFp%2FXICHSfuFUlwuFPOnX%2B2N9Mfp2EMNY2mEd8%2FD3cyofU8RYOYjqyy3UznhaCpvZ3fweLQ5%2FVTRXyoL%2FxD%2BeZ5mJxTUD%2FD2aJ%2FHKzIt6T9djElG3MognHa%2FSewffK%2FO6olZiMK4KM5dcOB3z01FT6DVsqMvBIEcLLl9dx5p%2FGVyIJirOcM7r8MERchqfQCgjMmFRNttcEFCSBe%2FNkNiMeOtj9EwnPdqgrIyxrwFYzC7l0WYnpcZ54cKGaVNfyZWyEZzNuWbFiotJHoKS99%2Fo01imsCCuWh%2FLirV7%2B4jiQST6fYZhg8ZkvGQOlBLl9IWN4ogApWTZqPthgPVzQ19uCkZPmTWHWWGxsgEhQ%2FpEKP1EhFKke0ES4nziB2T2J%2B9Vk1Ql8wFMIrQPlLJ8jIjmxeZuKHUJDQEZjcvtRzqY62GU25pf0HkniwyyCCxiHBWiYe8m%2F%2FoovOKAeGf>

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/74706/<https://reviews.apache.org/r/74706/>

addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/TypeGenerator.java<https://reviews.apache.org/r/74706/diff/1/?file=2282471#file2282471line43>
 (Diff revision 1)
43

    public static void main(String[] args) {

Generating typedefs dynamically and adding them in Atlas would require Atlas 
admin privileges. Did you consider creating a model json file and adding to  
https://github.com/apache/atlas/tree/master/addons/models? This will cause 
Atlas server to create Couchbase typedefs during startup.


- Madhan Neethiraj


On October 30th, 2023, 7:44 p.m. UTC, Dmitrii Chechetkin wrote:
Review request for atlas.
By Dmitrii Chechetkin.

Updated Oct. 30, 2023, 7:44 p.m.
Repository: atlas
Description

We at couchbase developed a bridge for Atlas that connectes to our database 
using DCP, analyzes metadata for documents that are being stored/updated on the 
cluster and then sends the extracted metadata onto an Atlas instance.

Additional documentation on the bridge is provided in 
docs/src/documents/Hook/HookCouchbase.md

Testing

Testing done manually and there's also a couple of integration tests.

Diffs
·         addons/couchbase-bridge/pom.xml (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/AtlasConfig.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/CBConfig.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/CouchbaseHook.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/TypeGenerator.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/entities/CouchbaseAtlasEntity.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/entities/CouchbaseBucket.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/entities/CouchbaseCluster.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/entities/CouchbaseCollection.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/entities/CouchbaseField.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/entities/CouchbaseFieldType.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/java/com/couchbase/atlas/connector/entities/CouchbaseScope.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/main/resources/atlas-application.properties 
(PRE-CREATION)
·         
addons/couchbase-bridge/src/test/java/com/couchbase/atlas/connector/CouchbaseHookTest.java
 (PRE-CREATION)
·         
addons/couchbase-bridge/src/test/java/com/couchbase/atlas/connector/entities/CouchbaseAtlasEntityTest.java
 (PRE-CREATION)
·         addons/couchbase-bridge/src/test/resources/log4j.xml (PRE-CREATION)
·         distro/pom.xml (ed477dfbb)
·         distro/src/main/assemblies/atlas-couchbase-hook-package.xml 
(PRE-CREATION)
·         distro/src/main/assemblies/standalone-package.xml (3e2ca1c39)
·         docs/src/documents/Hook/HookCouchbase.md (PRE-CREATION)
·         pom.xml (f76d0ea04)

View Diff<https://reviews.apache.org/r/74706/diff/1/>

Disclaimer

The information contained in this communication from the sender is 
confidential. It is intended solely for use by the recipient and others 
authorized to receive it. If you are not the recipient, you are hereby notified 
that any disclosure, copying, distribution or taking action in relation of the 
contents of this information is strictly prohibited and may be unlawful.

This email has been scanned for viruses and malware, and may have been 
automatically archived by Mimecast, a leader in email security and cyber 
resilience. Mimecast integrates email defenses with brand protection, security 
awareness training, web security, compliance and other essential capabilities. 
Mimecast helps protect large and small organizations from malicious activity, 
human error and technology failure; and to lead the movement toward building a 
more resilient world. To find out more, visit our website.

Reply via email to