----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74902/#review226232 -----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java Lines 438 (patched) <https://reviews.apache.org/r/74902/#comment314475> Atlas can be used with other storage backends (like Cassandra) as well. This change is HBase specific, and wouldn't work with other storage backends. Please review and update with an alternate approach. webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 1151 (patched) <https://reviews.apache.org/r/74902/#comment314474> Following methods in AtlasMetricsUtil get the status of backend and index stores (HBase/Cassandra/Solr/ElasticSearch/..): - getBackendStoreStatus() - getIndexStoreStatus() Consider adding isHealthy() method in AtlasMetricsUtil and call from here. - Madhan Neethiraj On Feb. 21, 2024, 11:13 p.m., Disha Talreja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74902/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2024, 11:13 p.m.) > > > Review request for atlas, Jayendra Parab, Pinal Shah, and Radhika Kundam. > > > Bugs: ATLAS-4826 > https://issues.apache.org/jira/browse/ATLAS-4826 > > > Repository: atlas > > > Description > ------- > > In order to monitor the application health and be able to restart it if it is > unhealthy we need to check the: > 1) Liveness - if Atlas is live and running as expected > 2) Readyness - if Atlas is live and ready to accept client requests > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java > 83f57d139 > graphdb/janus/pom.xml 80fe82bfd > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java > 115b681cc > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 4d59fa3d6 > webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java > 5b16ba149 > > > Diff: https://reviews.apache.org/r/74902/diff/1/ > > > Testing > ------- > > > Thanks, > > Disha Talreja > >
