> On April 12, 2024, 7:38 a.m., Pinal Shah wrote: > > Ship It!
Glossary Updates will be handled in other jira - Pinal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74956/#review226388 ----------------------------------------------------------- On April 12, 2024, 7:22 a.m., Priyanshi Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74956/ > ----------------------------------------------------------- > > (Updated April 12, 2024, 7:22 a.m.) > > > Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and > Sheetal Shah. > > > Bugs: ATLAS-4847 > https://issues.apache.org/jira/browse/ATLAS-4847 > > > Repository: atlas > > > Description > ------- > > Steps to reproduce: > > 1. Create a hive_table entity and assign a term to it. > 2. Perform 1st incremental export of that entity without using changeMarker. > 3. Without any modification on that entity perform 2nd consecutive > incremental export with changeMarker from previous export. > > Result is it that it throws NullPointerException and export is failed. > > Problem: > > When an entity which has termed assigned was exported with changeMarker value > greater than value of lastModified time of that entity it resulted in > throwing NullPointerException. > > Solution: > > 1. NullPointerException occured because it was trying to fetch referred > entities of AtlasGlossary Object while performing export operation and as > AtlasGlossary didn't have any referred entities it gave raise this exception. > 2. This problem is solved by handling NullPointer before trying to fetch > referred entities. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > 4615c6c2f > > > Diff: https://reviews.apache.org/r/74956/diff/1/ > > > Testing > ------- > > Manual testing has been done for the same. > > PC link: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1608/ > > > Thanks, > > Priyanshi Shah > >
