----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74608/#review226400 -----------------------------------------------------------
Consider adding few samples and test cases, to make it easier to understand audit filter functioanlity. intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java Lines 221 (patched) <https://reviews.apache.org/r/74608/#comment314614> Consider annotating isDiscarded() and setDiscarded() with @JsonIgnore. repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 462 (patched) <https://reviews.apache.org/r/74608/#comment314615> prepareDataObject() seems expensive - especially given it will be executed for each entity operation in Atlas. Are all fields of AtlasEntity used in rules? repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java Lines 74 (patched) <https://reviews.apache.org/r/74608/#comment314611> this.rules could be updated between #74 and #81, with the call to setRules() (#41). Consider adding the following line before #74: final List<AtlasRule> rules = this.rules; repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java Lines 83 (patched) <https://reviews.apache.org/r/74608/#comment314612> This conversion seems expensive. Is this conversion necessary for every evalation of a rule? repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java Lines 97 (patched) <https://reviews.apache.org/r/74608/#comment314613> Rule evaluation continues even after ACCEPT result from a rule; is this necessary? webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 1327 (patched) <https://reviews.apache.org/r/74608/#comment314610> Doesn't "/audits/rules/all" conflict with "/audits/rules/{ruleGuid}" (line #1269 above)? - Madhan Neethiraj On April 4, 2024, 5:14 a.m., Sheetal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74608/ > ----------------------------------------------------------- > > (Updated April 4, 2024, 5:14 a.m.) > > > Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad > Pawar, Radhika Kundam, and Sidharth Mishra. > > > Bugs: ATLAS-4797 > https://issues.apache.org/jira/browse/ATLAS-4797 > > > Repository: atlas > > > Description > ------- > > Currently, Atlas has to persist all audit events without any constraints > which can make audit data grow exponentially after some time. > > This feature is specifically to reduce Atlas audit storage where generation > of audit events can be controlled based on the user's use-case/criteria > > Note: Audit data mentioned here is exclusive of Admin Audit Data which > persists in atlas_janus table. Filtering will be applicable to the entity > audit data which persists in ATLAS_ENTITY_AUDIT_EVENTS table. > > Precommit details : > Latest PC build (PASSED) : > build:https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1592/ > > > Diffs > ----- > > addons/hbase-bridge/pom.xml 278b6c6d3 > addons/hbase-testing-util/pom.xml c4f3a99ee > addons/hive-bridge-shim/pom.xml 39f16ceee > addons/hive-bridge/pom.xml 356ac9542 > addons/kafka-bridge/pom.xml 093db7229 > addons/models/0000-Area0/0010-base_model.json a4a9248ec > addons/sqoop-bridge/pom.xml 4b6eac98f > authorization/pom.xml 7a1108487 > distro/src/conf/atlas-application.properties b5734d7a8 > graphdb/api/pom.xml 4ba89b20f > graphdb/janus-hbase2/pom.xml 9ec087dbb > intg/pom.xml 43a172c1b > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 > intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java > 3afd27e7d > repository/pom.xml 8fd744b44 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > 9b011ab06 > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > b7f0dd5e2 > repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java > e63152475 > > repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java > PRE-CREATION > server-api/pom.xml de311c329 > test-tools/src/main/resources/solr/core-template/solrconfig.xml 7a0e8dd16 > webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java > e19beccb1 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 0025276bb > webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java > 268fca717 > > > Diff: https://reviews.apache.org/r/74608/diff/13/ > > > Testing > ------- > > Manual testing done > > > Thanks, > > Sheetal Shah > >
