----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74925/#review226408 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 472 (patched) <https://reviews.apache.org/r/74925/#comment314619> Consider replacing #472 - #482 with the following line: String modifiedString = StringUtils.strip(query, "*"); repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 484 (patched) <https://reviews.apache.org/r/74925/#comment314620> "StringUtils.isNotEmpty(modifiedString) && " doesn't seem needed here, as subsequent call to hastokenizeChar() already handles this condition. - Madhan Neethiraj On April 30, 2024, 12:22 p.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74925/ > ----------------------------------------------------------- > > (Updated April 30, 2024, 12:22 p.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal > Shah, and Sheetal Shah. > > > Bugs: ATLAS-4225 > https://issues.apache.org/jira/browse/ATLAS-4225 > > > Repository: atlas > > > Description > ------- > > Updated latest patch with synchronized code > > Creating this review request to track and close > https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync > with latest code > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 > intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java f117fb359 > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 9be6517e9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 01b88eb2f > repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b > > repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java > 282a3fd4a > > repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java > 121dca9f5 > > repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java > 3f9e74d11 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java > 1489b2760 > > > Diff: https://reviews.apache.org/r/74925/diff/6/ > > > Testing > ------- > > Testcases are added in the patch > PC is successful : > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1621/ > > > Thanks, > > chaitali > >
