-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74978/#review226449
-----------------------------------------------------------


Ship it!




Ship It!

- Jayendra Parab


On May 14, 2024, 4:52 a.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74978/
> -----------------------------------------------------------
> 
> (Updated May 14, 2024, 4:52 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nikhil Bonte, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-4861
>     https://issues.apache.org/jira/browse/ATLAS-4861
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Replicated Attributes:**
>  
> Users want knowledge of how the entities have landed into Atlas instance, if 
> they were created via hook ingestion or whether they were imported from 
> another Atlas instance.
> 
> This is addressed by 2 new attributes that are now part of Referenceable 
> entity type viz. replicatedFrom and replicatedTo.
>  
> **Current Behaviour:**
> 
> At the end of export/import, the entities which are exported/imported are 
> updated with the replicationTo/replicationFrom  respectively with the value 
> of AtlasServer object 
> Hence updating each and every entity takes much time.
> 
> **Improvement:**
> 
> Add flag to skip such updates.
> 
> **Example request for Export:**
> 
> curl -v -X POST -u admin:admin -H "Content-Type: application/json"  
> "http://<>/api/atlas/admin/export" -d 
> '{"itemsToExport":[{"typeName":"hive_db","uniqueAttributes":{"qualifiedName":"bsadp@hpchdd2"}}],"options":{"fetchType":"full","replicatedTo":"cm",**"skipUpdateReplicationAttr":"true"**},"fetchTypeOptionValue":"full","skipLineageOptionValue":false,"changeTokenFromOptions":0}}'
>   > test_noupdate.zip
> 
> **Example import-options.json for Import:**
> 
> {
>     "options": {
>                 "replicatedFrom":"cm",
>                 "skipUpdateReplicationAttr":true
>                 }
> }
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java 
> 878b1d8bc 
>   intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
> cbc1aa938 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 
> c4de0ed27 
> 
> 
> Diff: https://reviews.apache.org/r/74978/diff/1/
> 
> 
> Testing
> -------
> 
> Tests(~3000 entity)          w/o updates    with updates
> Export1                         11s          25s
> Export2                         12s          27s
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Reply via email to