----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75053/#review226583 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java Line 938 (original), 945 (patched) <https://reviews.apache.org/r/75053/#comment314859> The current warning message is the same for both scenarios of aborting the process, which can be confusing. Please consider using distinct warning messages for each scenario to enhance clarity. - Radhika Kundam On June 18, 2024, 12:43 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75053/ > ----------------------------------------------------------- > > (Updated June 18, 2024, 12:43 a.m.) > > > Review request for atlas, Ashutosh Mestry, chaitali, Disha Talreja, Jayendra > Parab, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sheetal Shah, and > Sidharth Mishra. > > > Bugs: ATLAS-4881 > https://issues.apache.org/jira/browse/ATLAS-4881 > > > Repository: atlas > > > Description > ------- > > - reduced noise in Atlas server log file by changing log levels during > notification processing from info to debug level > - error handling during notificaiton processing updated to not retry if > failure was due to invalid data (like entity-type not found) > - updated metrics log to include the total time taken to process a > notification > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/utils/AtlasPerfMetrics.java c72b2c3e2 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 7b02ac449 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveDbDDLPreprocessor.java > dcff0939d > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java > 083e343b0 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveTableDDLPreprocessor.java > 83d4d7c1a > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java > f930d9f35 > > > Diff: https://reviews.apache.org/r/75053/diff/1/ > > > Testing > ------- > > - verified that notification preprocessing doesn't print logs in info level > - pre-commit tests run: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1654/ > > > Thanks, > > Madhan Neethiraj > >
