-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75014/
-----------------------------------------------------------
(Updated July 11, 2024, 1:51 p.m.)
Review request for atlas, Mandar Ambawane and Pinal Shah.
Bugs: ATLAS-4867
https://issues.apache.org/jira/browse/ATLAS-4867
Repository: atlas
Description
-------
Metrics API : http://<>/api/atlas/admin/metrics
1. There is some information in the Metrics API response, which is not been
used like Count of the typeAndSubTypes, Active, deleted, Shell
Approach:
Identify time taken by the above counts
Take reading of metric api
Take reading of metric api without the above counts
2. Also we can get the total number of count of vertices and edges present in
graph
This helps in estimating the time on Reindexing Patch.
Also it may be helpful while debugging the escalations
Approach:
Embed this count in MetricUtil
Or
Create seperate API
Diffs (updated)
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
004cab9c8
intg/src/main/java/org/apache/atlas/model/graph/AtlasGraphDetails.java
PRE-CREATION
repository/src/main/java/org/apache/atlas/services/MetricsService.java
9ec2cd2cb
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
a13e07387
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
475756981
Diff: https://reviews.apache.org/r/75014/diff/2/
Changes: https://reviews.apache.org/r/75014/diff/1-2/
Testing (updated)
-------
With typeAndSubTypes data it took 217ms for Metric API
Without typeAndSubTypes data, it took 180ms for Metric API
Without typeAndSubTypes and include the graph vertex and edge count took almost
300++ ms
PC build:-
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1662/console
Create a new API to fetch the graph details.
Graph API Request :- http://<>/api/atlas/admin/graph
Response :-
{
"data": {
"general": {
"Graph:": {
"Graph:edgesCount": 286,
"Graph:verticesCount": 697
}
}
}
}
File Attachments (updated)
----------------
AtlasGraphDetails.java
https://reviews.apache.org/media/uploaded/files/2024/07/11/3199de1d-ba43-4951-bc01-d42462c38518__AtlasGraphDetails.java
Thanks,
Paresh Devalia
