-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75211/
-----------------------------------------------------------
(Updated Sept. 19, 2024, 7:49 a.m.)
Review request for atlas, Farhan Khan, Jayendra Parab, Madhan Neethiraj, and
Prasad Pawar.
Summary (updated)
-----------------
ATLAS-4894: [UI] 'Exclude SubTypes' and 'Exclude Sub-classifications' filter
should be removed from referred attributes tab of entity details page
Bugs: ATLAS-4894
https://issues.apache.org/jira/browse/ATLAS-4894
Repository: atlas
Description
-------
In UI, When we visit the 'Tables' tab section of a hive_db entity (or similar a
entity type), the two filters 'Exclude SubTypes' and 'Exclude
Sub-classifications' (see attached screenshot) are visible, but do not have any
functionality in this page because these only work in the context of Basic
Search. There are no properties being passed to these filters when user visits
the entity details of the page.
Also from a functional perspective, it doesn't make sense for classifications
or types to be filtered in an entity details page.
It is better that they should be removed for consistency, as these filters are
already removed from the 'Schema' tab of hive_table entities.
This fix also include name validation for glossary, term and category.
Diffs
-----
dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html
f8cfad616
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 3f62d970f
dashboardv2/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20
dashboardv2/public/js/views/search/RelationSearchResultLayoutView.js
61176b4f6
dashboardv2/public/js/views/search/SearchResultLayoutView.js c9e57ad73
dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html
6aa3fe185
dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 854908da3
dashboardv3/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20
dashboardv3/public/js/views/search/RelationSearchResultLayoutView.js
f277c4e5f
dashboardv3/public/js/views/search/SearchResultLayoutView.js 16db56623
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
87fc2cd49
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java
007b2f24e
Diff: https://reviews.apache.org/r/75211/diff/1/
Testing
-------
Build the Atlas with below command :-
mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true
Valdiated the below scenarios:-
1)profile table in entity detail page.
2)CRUD operation for glossary, term and category
PC has been passed:-
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1694/
Thanks,
Brijesh Bhalala
