----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75317/#review227136 -----------------------------------------------------------
dev-support/atlas-docker/.env Lines 27 (patched) <https://reviews.apache.org/r/75317/#comment315409> TARGETARCH shouldn't be specified in the environment; it should be defined by docker while building an image. Also, docker-compose files shouldn't require passing TARGETARCH. Instead, declare it in Dockerfiles - similar to Apache Ranger docker setup in https://github.com/apache/ranger/blob/master/dev-support/ranger-docker/Dockerfile.ranger#L22. - Madhan Neethiraj On Dec. 19, 2024, 6:24 p.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75317/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2024, 6:24 p.m.) > > > Review request for atlas, Jayendra Parab and Madhan Neethiraj. > > > Bugs: ATLAS-4949 > https://issues.apache.org/jira/browse/ATLAS-4949 > > > Repository: atlas > > > Description > ------- > > Few issues while building atlas docker > > - download-archieves.sh file permission is not retained, > - if downloads folder is not present, it fails to write the files > - TARGETARCH argument failing to replace the value > > > Diffs > ----- > > dev-support/atlas-docker/.env 8e608f795 > dev-support/atlas-docker/README.md 694d8dbe6 > dev-support/atlas-docker/docker-compose.atlas-base.yml 29f92a142 > dev-support/atlas-docker/docker-compose.atlas-build.yml f73874b39 > dev-support/atlas-docker/docker-compose.atlas.yml b21540571 > dev-support/atlas-docker/download-archives.sh b5ede35ab > > > Diff: https://reviews.apache.org/r/75317/diff/1/ > > > Testing > ------- > > Manually verified changes > > > Thanks, > > Pinal Shah > >
