----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75322/#review227141 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Dec. 20, 2024, 10:45 p.m., Abhishek Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75322/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2024, 10:45 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-4944 > https://issues.apache.org/jira/browse/ATLAS-4944 > > > Repository: atlas > > > Description > ------- > > Legacy Key Value format used for defining ENV and ARG in Dockerfiles has been > deprecated, for more info: > > https://docs.docker.com/reference/build-checks/legacy-key-value-format/ > > https://docs.docker.com/reference/dockerfile/#env > > > > The Dockerfiles should be updated to use the below format: > > ENV key=value > > ARG key=value > > > Diffs > ----- > > dev-support/atlas-docker/Dockerfile 12c1b6ea2 > dev-support/atlas-docker/Dockerfile.atlas 83550c5f1 > dev-support/atlas-docker/Dockerfile.atlas-base 6a39586b7 > dev-support/atlas-docker/Dockerfile.atlas-build 42a2536ee > dev-support/atlas-docker/Dockerfile.atlas-db b596809c4 > dev-support/atlas-docker/Dockerfile.atlas-hadoop 26e766e7c > dev-support/atlas-docker/Dockerfile.atlas-hbase 6b4b6edd9 > dev-support/atlas-docker/Dockerfile.atlas-hive 23b637f3e > dev-support/atlas-docker/Dockerfile.atlas-kafka d7a8e3f07 > dev-support/atlas-docker/Dockerfile.atlas-solr 17c14bb74 > > > Diff: https://reviews.apache.org/r/75322/diff/1/ > > > Testing > ------- > > Followed README to bring all the containers up, verified the ENV variables > via Inspect in Docker Desktop. > > > Thanks, > > Abhishek Kumar > >
