----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75340/ -----------------------------------------------------------
(Updated Jan. 22, 2025, 9:23 a.m.) Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and Sheetal Shah. Summary (updated) ----------------- ATLAS-4955 : Different TypeDef table were created, but not able to seen under hive_db entity. Bugs: ATLAS-4955 https://issues.apache.org/jira/browse/ATLAS-4955 Repository: atlas Description ------- In hive_db entity's table tab and relationship tabĀ Apart from hive_table typeDef, we are not able to show the relationShip of other tables. When we create hive tables and different typeDef table under same hive_db it doesn't show both types of tables under tables tab table. It only show hive_table typeDef table. This works as designed because we only show tables of single typename currently.This will require improvement in order to fetch all available tables even for multiple typenames. Diffs (updated) ----- dashboardv2/public/js/views/search/SearchResultLayoutView.js 6f990f2f7 dashboardv3/public/js/views/search/SearchResultLayoutView.js 7abfd56a3 repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java acab4ce0a repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java dc3acf695 repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java d5112bbf6 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java b96d5ce30 webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java b15f662d0 Diff: https://reviews.apache.org/r/75340/diff/3/ Changes: https://reviews.apache.org/r/75340/diff/2-3/ Testing ------- Manaully Test creatng different typeDef table and were able to fetch deatils for relationship and table tab. In EntityDiscoveryService.java added new method searchRelatedEntities which take <List> relations. No logical changes are done in this method, only iterate the list. In GraphHelper.java added new getRelationshipTypeNameList which return the list of relationshipTypes on bases of attribute. Previously it was returning string. Thanks, Paresh Devalia