----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75296/#review227198 -----------------------------------------------------------
Ship it! Ship It! - Pinal Shah On Jan. 14, 2025, 7:47 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75296/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2025, 7:47 p.m.) > > > Review request for atlas, Ashutosh Mestry, Disha Talreja, Jayendra Parab, > Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-4937 > https://issues.apache.org/jira/browse/ATLAS-4937 > > > Repository: atlas > > > Description > ------- > > - replaced checkstyle.xml used with a version based on > https://github.com/airlift/airbase/blob/master/airbase-policy/src/main/resources/checkstyle/airbase-checks.xml > - added AtlasCodeScheme-IntelliJ.xml, to make it easier to adhere to > checkstyle requirements > > > Diffs > ----- > > build-tools/src/main/resources/checkstyle-suppressions.xml 759a52ec7 > build-tools/src/main/resources/checkstyle.xml 54423176f > dev-support/AtlasCodeScheme-IntelliJ.xml PRE-CREATION > dev-support/checkstyle.xml PRE-CREATION > pom.xml f48bf6cc0 > > > Diff: https://reviews.apache.org/r/75296/diff/2/ > > > Testing > ------- > > - verified that build succeeds with updated checkstyle i.e. checkstyle > violations will be reported during build, but will not fail the build > - Precommit tests run: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1769/ > > > Thanks, > > Madhan Neethiraj > >
