[ https://issues.apache.org/jira/browse/ATLAS-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916799#comment-17916799 ]
ASF subversion and git services commented on ATLAS-4937: -------------------------------------------------------- Commit 4e10950f0b83082cfd16b80b5af7e08fb9e10445 in atlas's branch refs/heads/atlas-2.5 from Madhan Neethiraj [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4e10950f0 ] ATLAS-4937: update checkstyle to improve code readability (#269) (cherry picked from commit e25a32d045b8689174efb8f3046ba19a5c56dfb6) > Code readability improvement > ---------------------------- > > Key: ATLAS-4937 > URL: https://issues.apache.org/jira/browse/ATLAS-4937 > Project: Atlas > Issue Type: Improvement > Components: atlas-core, atlas-intg, atlas-webui > Reporter: Madhan Neethiraj > Assignee: Madhan Neethiraj > Priority: Major > Fix For: 3.0.0 > > Attachments: ATLAS-4937.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > Atlas code base has been evolving over many years, with contributions from > large number of authors. Having a common coding style enforced during build > time will help improve the readability of the code base. I propose to use > [checkstyle|https://github.com/airlift/airbase/blob/master/airbase-policy/src/main/resources/checkstyle/airbase-checks.xml] > based on airbase, which is used by open-source projects like Trino. > Updating the entire code base will take considerable time, hence this will > need to be done in phases, perhaps one module at a time. To start with, I > suggest updating the checkstyle currently in the master branch but not fail > the build in case of violations. This should be followed by updates to > sources to comply with the checkstyle - one module at a time. Once all > modules are updated, build should be updated to fail on violations. -- This message was sent by Atlassian Jira (v8.20.10#820010)