chaitalicod commented on code in PR #313:
URL: https://github.com/apache/atlas/pull/313#discussion_r2017929944
##########
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java:
##########
@@ -179,6 +179,8 @@ public enum AtlasErrorCode {
LINEAGE_ON_DEMAND_NOT_ENABLED(400, "ATLAS-400-00-100", "Lineage on demand
config: {0} is not enabled"),
INVALID_TOPIC_NAME(400, "ATLAS-400-00-101", "Unsupported topic name :
{0}"),
UNSUPPORTED_TYPE_NAME(400, "ATLAS-400-00-102", "Unsupported {0} name.
Names such as 'description','version','options','name','servicetype' are not
supported"),
+ INVALID_OPERATOR_PASSED(400, "ATLAS-400-00-103", "Invalid Operator Passed:
for attribute name: {0}"),
Review Comment:
Can you rename this to INVALID_OPERATOR?
##########
webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java:
##########
@@ -138,6 +138,11 @@ public void testDiscoveryWithSearchParameters(String
jsonFile) {
LOG.info("TestDescription :{}",
testExpectation.testDescription);
LOG.info("SearchParameters :{}",
testExpectation.searchParameters);
+ SearchParameters parameters =
testExpectation.getSearchParameters();
+ if (parameters.getEntityFilters() == null ||
parameters.getEntityFilters().getAttributeName() == null) {
+ continue;
+ }
Review Comment:
This check is good but Can you confirm with a usecase if this is getting
checked or addressing invalid values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
