sheetalshah1007 commented on code in PR #327:
URL: https://github.com/apache/atlas/pull/327#discussion_r2046219607
##########
webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java:
##########
@@ -224,6 +248,43 @@ public void testSavedSearch(String jsonFile) {
}
}
+ @Test(dataProvider = "invalidOperatorTestFiles")
Review Comment:
`@DataProvider` is useful when multiple variations of input data are needed
to test different scenarios. Since there is no variation in test data
(`jsonFile` in your case), `@DataProvider` is unnecessary; you can remove it
and inline the relevant filename inside the respective test methods
(`testAttributeSearchInvalidOperator, testAttributeSearchEmptyNameAttribute,
testAttributeSearchEmptyValueAttribute`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
