mneethiraj commented on code in PR #374:
URL: https://github.com/apache/atlas/pull/374#discussion_r2192627062
##########
authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java:
##########
@@ -173,13 +172,13 @@ public String getEntityId(AtlasEntityHeader entity,
AtlasTypeRegistry typeRegist
public Set<String> getClassificationNames(AtlasEntityHeader entity) {
final Set<String> ret;
- if (entity == null || entity.getClassifications() == null) {
+ if (entity == null || entity.getClassificationNames() == null) {
ret = Collections.emptySet();
} else {
ret = new HashSet<>();
- for (AtlasClassification classify : entity.getClassifications()) {
- ret.add(classify.getTypeName());
+ for (String classify : entity.getClassificationNames()) {
Review Comment:
I suggest replacing lines 178 to 182 with the following:
```
ret = new HashSet<>(entity.getClassificationNames());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
