chaitalicod commented on code in PR #471:
URL: https://github.com/apache/atlas/pull/471#discussion_r2633741618
##########
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java:
##########
@@ -401,7 +399,26 @@ private String getListenerName(EntityChangeListener
listener) {
}
private boolean skipAuditEntries(List<AtlasEntityHeader> entityHeaders) {
- return CollectionUtils.isEmpty(entityHeaders) ||
entityHeaders.stream().noneMatch(PRED_IS_NOT_TYPE_AUDIT_ENTITY);
+ if (CollectionUtils.isEmpty(entityHeaders)) {
+ return true;
+ }
+
+ // Skip audit if ALL entities are internal types (__AtlasAuditEntry,
__AtlasMetricsStat, etc.)
Review Comment:
check if you can make your comments more precise and short?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
