mneethiraj commented on code in PR #540:
URL: https://github.com/apache/atlas/pull/540#discussion_r2841514697
##########
dev-support/atlas-docker/scripts/atlas-build.sh:
##########
@@ -86,15 +86,25 @@ else
done
fi
-mvn ${ARG_PROFILES} ${ARG_SKIPTESTS} -DskipDocs clean package
-
-mv -f distro/target/apache-atlas-${ATLAS_VERSION}-server.tar.gz
/home/atlas/dist/
-mv -f distro/target/apache-atlas-${ATLAS_VERSION}-hive-hook.tar.gz
/home/atlas/dist/
-mv -f distro/target/apache-atlas-${ATLAS_VERSION}-hbase-hook.tar.gz
/home/atlas/dist/
-mv -f distro/target/apache-atlas-${ATLAS_VERSION}-kafka-hook.tar.gz
/home/atlas/dist/
+if [[ "${PROFILE}" == *"embedded-solr-it"* ]]; then
Review Comment:
For better readability, I suggest replacing `PROFILE` with `ARG_PROFILES`,
as the `ARG_PROFILES` is referenced in if and else blocks.
Is use of "-X" the intended difference between if/else blocks? Isn't verify
needed in else block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
