pinal-shah commented on code in PR #609:
URL: https://github.com/apache/atlas/pull/609#discussion_r3218844694
##########
addons/models/6000-Trino/patches/001-rename_propagation_typedef_patch.json:
##########
@@ -0,0 +1,29 @@
+{
Review Comment:
Do you need patch? since trino models are not yet released.
##########
addons/models/6000-Trino/6000-trino_model.json:
##########
@@ -25,6 +25,12 @@
"superTypes": [ "Asset" ],
"serviceType": "trino",
"typeVersion": "1.0",
+ "attributeDefOverrides": [
Review Comment:
Please update to trino_columns typeDef
##########
addons/models/6000-Trino/6000-trino_model.json:
##########
@@ -25,6 +25,12 @@
"superTypes": [ "Asset" ],
"serviceType": "trino",
"typeVersion": "1.0",
+ "attributeDefOverrides": [
+ {
+ "name": "qualifiedName",
+ "autoComputeFormat":
"{table.trinoschema.catalog.name}.{table.trinoschema.name}.{table.name}.{name}@{table.trinoschema.catalog.instance.name}"
Review Comment:
Since ".name" we have hardcoded as the name attribute of a particular type
in the processing os autoComputeFormat, Please highlight or create a doc, on
how to add the format for an entityType
##########
intg/src/main/java/org/apache/atlas/type/RenamePropagationTarget.java:
##########
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.atlas.type;
+
+import
org.apache.atlas.model.typedef.AtlasRelationshipDef.RelationshipCategory;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+
+/**
+ * Typedef-time representation of a rename propagation target for an entity
type.
+ */
+public class RenamePropagationTarget {
+ private final String targetTypeName;
+ private final RelationshipCategory category;
Review Comment:
please review, if this is needed.
##########
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java:
##########
@@ -1179,6 +1180,120 @@ public PatchStatus applyPatch(TypeDefPatch patch)
throws AtlasBaseException {
}
}
+ /**
+ * Applies {@code SET_ATTRIBUTE_DEF_OVERRIDES} on entity typedefs and
{@code SET_PROPAGATE_RENAME} on relationship typedefs.
+ */
+ static class SetAttributeDefOverridesPatchHandler extends PatchHandler {
Review Comment:
Since this class handles different actions, not just
SetAttributeDefOverrides, Please rename accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
