pareshddevalia commented on code in PR #640:
URL: https://github.com/apache/atlas/pull/640#discussion_r3527770405
##########
addons/hbase-bridge/pom.xml:
##########
@@ -512,6 +644,16 @@
<artifactId>atlas-client-v2</artifactId>
<version>${project.version}</version>
</artifactItem>
+ <artifactItem>
+ <groupId>javax.inject</groupId>
+
<artifactId>javax.inject</artifactId>
+
<version>${javax-inject.version}</version>
+ </artifactItem>
+ <artifactItem>
+ <groupId>javax.annotation</groupId>
+
<artifactId>javax.annotation-api</artifactId>
+ <version>1.3.2</version>
Review Comment:
can we keep the version in pom.xml files
##########
addons/hbase-bridge/pom.xml:
##########
@@ -297,6 +415,20 @@
<build>
<plugins>
+ <!-- Parent disables Failsafe forking (forkCount=0). Fork IT JVM
for stable Atlas client + Hadoop minicluster. -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
Review Comment:
What was the need here <artifactId>maven-failsafe-plugin</artifactId> ?
##########
addons/impala-bridge/pom.xml:
##########
@@ -543,5 +627,22 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>hive-it-jdk17</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <configuration combine.self="merge">
Review Comment:
Same as here
##########
addons/impala-bridge/pom.xml:
##########
@@ -227,9 +284,31 @@
<artifactId>jetty-server</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.glassfish.jersey.core</groupId>
+ <artifactId>jersey-server</artifactId>
+ <version>${jersey2.version}</version>
+ <scope>test</scope>
+ </dependency>
</dependencies>
<build>
<plugins>
+ <!-- Parent disables Failsafe forking (forkCount=0). Fork IT JVM;
on Java 9+ use
+ HiveITSystemClassLoader so Hive 3.1.x SessionState sees a
URLClassLoader. -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
Review Comment:
Why these plugin is needed?
##########
addons/hbase-bridge/pom.xml:
##########
@@ -582,20 +724,61 @@
<artifactId>commons-configuration2</artifactId>
<version>${commons-conf2.version}</version>
</artifactItem>
+ <!-- Hadoop metrics/UGI still uses
commons-configuration 1.x API -->
+ <artifactItem>
+
<groupId>commons-configuration</groupId>
+
<artifactId>commons-configuration</artifactId>
+ <version>1.10</version>
Review Comment:
common-configuration 1.10 is need? we have already upgraded to 2
##########
addons/falcon-bridge/pom.xml:
##########
@@ -120,6 +136,22 @@
<build>
<plugins>
+ <!-- Parent disables Failsafe forking (forkCount=0). Exclude
shaded v2 client from IT classpath
+ to avoid Jersey NoSuchMethodError on
org.apache.atlas.shaded.javax.ws.rs.RuntimeType. -->
Review Comment:
What was the need here maven-failsafe-plugin ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
