Brijesh619 commented on code in PR #688:
URL: https://github.com/apache/atlas/pull/688#discussion_r3543908363
##########
dashboard/src/views/SideBar/SideBarBody.tsx:
##########
@@ -482,15 +763,27 @@ const SideBarBody = (props: {
<div
style={{
width: "100%",
- textAlign: "right",
padding: "8px",
position: "sticky",
bottom: "0px",
zIndex: "9",
left: "0",
background: "#034858",
+ display: "flex",
+ flexDirection: open ? "row" : "column",
+ justifyContent: open ? "space-between" : "center",
+ alignItems: "center",
+ gap: open ? "0px" : "4px"
}}
>
+ {open && (
+ <Box display="flex" flexDirection="column" gap="4px"
alignItems="flex-start" pl="4px">
+ <Typography variant="body2" sx={{ color: "rgba(255, 255, 255,
0.6)", pl: '4px' }}>
+ V {versionData?.Version || '3.12.1.0'}
Review Comment:
Done! Removed the hardcoded version fallback so it will only render if the
version data is successfully fetched.
##########
dashboard/src/views/SideBar/SideBarBody.tsx:
##########
@@ -156,6 +210,17 @@ const SideBarBody = (props: {
dispatch(fetchRootClassification());
dispatch(fetchEnumData());
dispatch(fetchMetricEntity());
+
+ // Fetch version data for footer
+ const fetchVersion = async () => {
+ try {
+ const resp = await getVersion();
Review Comment:
Resolved! Centralized version fetching into sessionSlice (Redux) to avoid
duplicate API calls between SideBarBody and About, and also added the required
unit tests for it.
##########
dashboard/src/styles/sidebar.scss:
##########
@@ -196,6 +212,17 @@
border-bottom: "1px solid rgba(25,255,255,0.1)";
}
+.light-popover {
Review Comment:
Removed the unused .light-popover class from sidebar.scss as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
