Brijesh619 commented on code in PR #728: URL: https://github.com/apache/atlas/pull/728#discussion_r3820779479
##########
dashboard/src/views/DashboardOverview/LatestEntitiesList.tsx:
##########
@@ -207,55 +192,40 @@ const LatestEntitiesList = memo(({ entities, isLoading,
error }: LatestEntitiesL
<ListItem
key={entityGuid
|| displayName}
disablePadding
- sx={{
- py: 1,
-
borderBottom: "1px solid",
-
borderColor: "divider",
-
"&:last-child": { borderBottom: "none" }
- }}
+
className="latest-entities-list-item"
>
<Stack
width="100%" direction="row" justifyContent="space-between" alignItems="center">
- <Stack
direction="row" spacing={0.5} alignItems="center" flexWrap="wrap" flex={1}
minWidth={0} mr={1}>
+ <Stack
direction="row" spacing={0.5} alignItems="center" flexWrap="nowrap" flex={1}
minWidth={0} mr={1}>
{detailHref ? (
-
<Link
-
component={RouterLink}
-
to={detailHref}
-
underline="hover"
-
color="primary"
-
sx={{
-
fontSize: "0.875rem",
-
overflow: "hidden",
-
textOverflow: "ellipsis",
-
cursor: "pointer",
-
maxWidth: "100%"
-
}}
-
>
-
{displayName}
-
</Link>
+
<OverflowTooltip title={displayName} arrow placement="top">
+
<Link
+
component={RouterLink}
+
to={detailHref}
+
underline="hover"
+
color="primary"
+
className="latest-entities-entity-name
latest-entities-entity-name-link"
+
>
+
{displayName}
+
</Link>
+
</OverflowTooltip>
) : (
-
<Typography
-
component="span"
-
sx={{
-
fontSize: "0.875rem",
-
fontWeight: 500,
-
color: "text.primary"
-
}}
-
>
-
{displayName}
-
</Typography>
+
<OverflowTooltip title={displayName} arrow placement="top">
+
<Typography
+
component="span"
+
className="latest-entities-entity-name
latest-entities-entity-name-fallback"
+
>
+
{displayName}
+
</Typography>
+
</OverflowTooltip>
)}
<Typography
component="span"
-
sx={{
-
fontSize: "0.875rem",
-
color: "#6c757d",
-
flexShrink: 0
-
}}
+
className="latest-entities-type-name"
Review Comment:
Fixed. Allowed the type name to shrink (`flex-shrink: 1`, `min-width: 0`)
and added truncation styles (`text-overflow: ellipsis`, `white-space: nowrap`,
`overflow: hidden`). The `typeName` is now wrapped in an `OverflowTooltip` as
well, ensuring that long type names don't break the layout and remain fully
readable on hover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
