Brijesh619 commented on code in PR #688:
URL: https://github.com/apache/atlas/pull/688#discussion_r3844652625
##########
dashboard/src/views/SideBar/SideBarTree/__tests__/SideBarTree.test.tsx:
##########
@@ -27,6 +27,7 @@
*/
import React from 'react'
+import '@testing-library/jest-dom'
import { render, screen, waitFor, fireEvent, act, cleanup } from
'@testing-library/react'
Review Comment:
Added the missing test cases to SideBarBody.test.tsx to verify that the
module popover correctly closes when the Escape key is pressed, and added a
specific test to assert that the version footer is correctly hidden when the
sidebar is collapsed.
##########
dashboard/src/views/SideBar/SideBarBody.tsx:
##########
@@ -210,30 +300,32 @@ const SideBarBody = (props: {
<Drawer
sx={{
- width: position,
+ width: open ? defaultDrawerWidth : "60px",
Review Comment:
Here is a single resolve comment you can use for the thread:
> I have refactored all heavily nested inline `sx` instances across
`SideBarBody.tsx` (including the Drawer config, Popover `PaperProps`, module
icon hover states, and the version footer) into proper SCSS classes inside
`sidebar.scss` to handle layout and dynamic states cleanly. Additionally, I've
updated `AGENTS.md` with an explicit "AUTO-REJECT CRITERIA for Inline Styling"
rule so our AI reviewers will aggressively flag and catch these issues going
forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
