Copilot commented on code in PR #782:
URL: https://github.com/apache/atlas/pull/782#discussion_r4294107871
##########
addons/models/7000-Iceberg/7010-iceberg_model.json:
##########
@@ -0,0 +1,320 @@
+{
+ "enumDefs": [
+ {
+ "name": "iceberg_catalog_type",
+ "description": "Storage ownership model for an Iceberg REST catalog",
+ "serviceType": "iceberg",
+ "typeVersion": "1.0",
+ "elementDefs": [
+ { "ordinal": 0, "value": "INTERNAL" },
+ { "ordinal": 1, "value": "EXTERNAL" }
+ ]
+ },
+ {
+ "name": "iceberg_table_format_version",
+ "description": "Iceberg table or view format version",
+ "serviceType": "iceberg",
+ "typeVersion": "1.0",
+ "elementDefs": [
+ { "ordinal": 1, "value": "V1" },
+ { "ordinal": 2, "value": "V2" },
+ { "ordinal": 3, "value": "V3" }
+ ]
+ },
+ {
+ "name": "iceberg_operation_type",
+ "description": "Catalog operation recorded by an iceberg_ddl audit
entity",
+ "serviceType": "iceberg",
+ "typeVersion": "1.0",
+ "elementDefs": [
+ { "ordinal": 0, "value": "CREATE_CATALOG" },
+ { "ordinal": 1, "value": "UPDATE_CATALOG" },
+ { "ordinal": 2, "value": "DELETE_CATALOG" },
+ { "ordinal": 3, "value": "CREATE_NAMESPACE" },
+ { "ordinal": 4, "value": "DROP_NAMESPACE" },
+ { "ordinal": 5, "value": "UPDATE_NAMESPACE_PROPERTIES" },
+ { "ordinal": 6, "value": "CREATE_TABLE" },
+ { "ordinal": 7, "value": "UPDATE_TABLE" },
+ { "ordinal": 8, "value": "DROP_TABLE" },
+ { "ordinal": 9, "value": "REGISTER_TABLE" },
+ { "ordinal": 10, "value": "RENAME_TABLE" },
+ { "ordinal": 11, "value": "CREATE_VIEW" },
+ { "ordinal": 12, "value": "REPLACE_VIEW" },
+ { "ordinal": 13, "value": "DROP_VIEW" },
+ { "ordinal": 14, "value": "RENAME_VIEW" }
+ ]
+ }
+ ],
+ "entityDefs": [
+ {
+ "name": "iceberg_catalog",
+ "description": "A catalog exposed by an Iceberg REST catalog service",
+ "superTypes": [ "Asset" ],
+ "serviceType": "iceberg",
+ "typeVersion": "1.0",
+ "attributeDefs": [
+ { "name": "clusterName", "typeName": "string",
"cardinality": "SINGLE", "isIndexable": true, "isOptional": false, "isUnique":
false, "includeInNotification": true },
+ { "name": "realmId", "typeName": "string",
"cardinality": "SINGLE", "isIndexable": true, "isOptional": false, "isUnique":
false, "includeInNotification": true },
+ { "name": "catalogType", "typeName": "iceberg_catalog_type",
"cardinality": "SINGLE", "isIndexable": true, "isOptional": true, "isUnique":
false },
+ { "name": "storageType", "typeName": "string",
"cardinality": "SINGLE", "isIndexable": true, "isOptional": true, "isUnique":
false },
+ { "name": "defaultBaseLocation", "typeName": "string",
"cardinality": "SINGLE", "isIndexable": false, "isOptional": true, "isUnique":
false },
+ { "name": "properties", "typeName": "map<string,string>",
"cardinality": "SINGLE", "isIndexable": false, "isOptional": true, "isUnique":
false }
+ ]
+ },
+ {
+ "name": "iceberg_namespace",
+ "description": "An Iceberg namespace within a catalog; nests
arbitrarily deep",
+ "superTypes": [ "Asset" ],
+ "serviceType": "iceberg",
+ "typeVersion": "1.0",
+ "attributeDefs": [
+ { "name": "clusterName", "typeName": "string",
"cardinality": "SINGLE", "isIndexable": true, "isOptional": false, "isUnique":
false, "includeInNotification": true },
+ { "name": "realmId", "typeName": "string",
"cardinality": "SINGLE", "isIndexable": true, "isOptional": false, "isUnique":
false, "includeInNotification": true },
+ { "name": "levels", "typeName": "array<string>",
"cardinality": "SINGLE", "isIndexable": false, "isOptional": false, "isUnique":
false },
+ { "name": "location", "typeName": "string",
"cardinality": "SINGLE", "isIndexable": false, "isOptional": true, "isUnique":
false },
+ { "name": "properties", "typeName": "map<string,string>",
"cardinality": "SINGLE", "isIndexable": false, "isOptional": true, "isUnique":
false }
+ ]
+ },
+ {
+ "name": "iceberg_table",
+ "description": "An Iceberg table or view within a namespace; tableType
discriminates. Mirrors Hive, where a view is a hive_table with
tableType=VIRTUAL_VIEW rather than a separate type.",
+ "superTypes": [ "DataSet" ],
+ "serviceType": "iceberg",
+ "typeVersion": "1.0",
Review Comment:
`iceberg_table` lacks `options.schemaElementsAttribute`, so both Atlas
dashboards hide its Schema tab even when the `columns` relationship is
populated (`dashboard/src/views/DetailPage/EntityDetailPage.tsx:145–181` and
`dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js:414–430`). Add
the option pointing to `columns`, as `hive_table` does, so imported Iceberg
tables and views expose their schemas in the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
