achandel-01 commented on code in PR #778:
URL: https://github.com/apache/atlas/pull/778#discussion_r4479793790
##########
webapp/src/main/java/org/apache/atlas/notification/SerialEntityProcessor.java:
##########
@@ -455,6 +460,23 @@ public TopicPartitionOffsetResult handleMessage(Ticket
ticket) {
return new
TopicPartitionOffsetResult(kafkaMsg.getTopicPartition(), kafkaMsg.getOffset());
}
+ try {
+ validateEntityTypeNames(message);
Review Comment:
Why aren’t all hook notification types handled upfront in
validateEntityTypeNames() — only ENTITY_*? I see isRetryableException() as
backup for the rest; is that the intended split ?
##########
webapp/src/main/java/org/apache/atlas/notification/SerialEntityProcessor.java:
##########
@@ -455,6 +460,23 @@ public TopicPartitionOffsetResult handleMessage(Ticket
ticket) {
return new
TopicPartitionOffsetResult(kafkaMsg.getTopicPartition(), kafkaMsg.getOffset());
}
+ try {
+ validateEntityTypeNames(message);
Review Comment:
why not calling validateEntityTypeNames(message) before the
preProcessNotificationMessage(kafkaMsg) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]