> On July 10, 2015, 5:05 p.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/Main.java, line 103 > > <https://reviews.apache.org/r/36359/diff/1/?file=1003745#file1003745line103> > > > > Could remove protected to make it package private. Dont get what a > > protected static method means. > > Jonathan Maron wrote: > I'm not sure about the qualifier either, but making it protected enabled > a better testing approach and didn't seem to expose the internals in a > detrimental way. > > Jonathan Maron wrote: > Actually, I imagine "protected" means that the method can be statically > invoked from child classes or from within the same package.
Since we need the method only in MainIT, the test which is in same package, we can drop the protected and make it static int getApplicationPort(CommandLine cmd,.... IMO. No need to have protected. - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36359/#review91320 ----------------------------------------------------------- On July 9, 2015, 6:06 p.m., Jonathan Maron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36359/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 6:06 p.m.) > > > Review request for atlas, Arpit Gupta and Seetharam Venkatesh. > > > Bugs: ATLAS-36 > https://issues.apache.org/jira/browse/ATLAS-36 > > > Repository: atlas > > > Description > ------- > > Distinct HTTP and HTTPS persisted port properties will make the configuration > clearer and allow for a better experience from management interfaces such as > Ambari. > > > Diffs > ----- > > src/conf/application.properties 6c4c7d2 > webapp/src/main/java/org/apache/atlas/Main.java 1dd17b4 > webapp/src/test/java/org/apache/atlas/MainIT.java PRE-CREATION > > Diff: https://reviews.apache.org/r/36359/diff/ > > > Testing > ------- > > Installed a local server and observed the configuration properties working. > Added a unit test for port selection logic (MainIT). > > > Thanks, > > Jonathan Maron > >
