[
https://issues.apache.org/jira/browse/ATLAS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642873#comment-14642873
]
Jonathan Maron edited comment on ATLAS-80 at 7/27/15 3:30 PM:
--------------------------------------------------------------
A few questions (none that require re-opening :) ):
1) in ApplicaitonProperties.get, the loop to print out values if debug enabled
gets executed whether debug is enabled or not. Not sure if it's truly that
expensive to retrieve values, but maybe this block should be guarded with a
logger.isDebugEnabled() call?
2) Why were SecurityProperties changed from 'static final'?
was (Author: jmaron):
A few questions (none that require re-opening :) ):
1) in ApplicaitonProperties.get, the loop to print out values if debug enabled
gets executed whether debug is enabled or not. Not sure if it's truly that
expensive to retrieve values, but maybe this block should be guarded with a
logger.isDebugEnabled() call?
2) Why were SecurityProperties changes from 'static final'?
> Support for variables in application properties
> -----------------------------------------------
>
> Key: ATLAS-80
> URL: https://issues.apache.org/jira/browse/ATLAS-80
> Project: Atlas
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
> Fix For: trunk
>
> Attachments: ATLAS-80-v2.patch, ATLAS-80.patch
>
>
> We use commons-configuration for application properties and 1.x that we use
> doesn't support variables in properties. 2.x has support for variables, but
> is in beta and is not production ready.
> Meanwhile, we can support it using EL expression and substitute using system
> properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
