----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37653/#review95971 -----------------------------------------------------------
pom.xml (line 1456) <https://reviews.apache.org/r/37653/#comment151163> Lets not do this. Lets not bundle log4j with client and we should be good. - Seetharam Venkatesh On Aug. 20, 2015, 3:01 p.m., Jonathan Maron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37653/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 3:01 p.m.) > > > Review request for atlas and Tom Beerbower. > > > Bugs: ATLAS-118 > https://issues.apache.org/jira/browse/ATLAS-118 > > > Repository: atlas > > > Description > ------- > > Using the standard log4j.xml or log4j.properties file names for the atlas > logging configuration can lead to issues with other projects attempting to > load their own logging configuration. > > > Diffs > ----- > > pom.xml 3d729b5 > src/bin/atlas_start.py 66e8735 > src/bin/quick_start.py e675e8b > src/conf/atlas-log4j.xml PRE-CREATION > src/conf/log4j.xml 887cae5 > src/test/python/scripts/TestMetadata.py bb250cb > webapp/src/main/resources/atlas-log4j.xml PRE-CREATION > webapp/src/main/resources/log4j.xml 7827c1a > > Diff: https://reviews.apache.org/r/37653/diff/ > > > Testing > ------- > > All atlas unit tests > Package and deployment to local host to ensure the logging is still behaving > as expected. > > > Thanks, > > Jonathan Maron > >
