-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37689/
-----------------------------------------------------------

(Updated Aug. 23, 2015, 6:15 p.m.)


Review request for atlas, Jonathan Maron and Seetharam Venkatesh.


Changes
-------

Fixed for verify


Bugs: ATLAS-116
    https://issues.apache.org/jira/browse/ATLAS-116


Repository: atlas


Description
-------

Building the Atlas project using:

    export MAVEN_OPTS="-Xmx1024m -XX:MaxPermSize=256m" && mvn clean install 
-Dmaven.test.skip=true


fails with the following error message:

[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
atlas-webapp ---
[INFO] Not compiling test sources
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ atlas-webapp ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-war-plugin:2.4:war (default-war) @ atlas-webapp ---
[INFO] Packaging webapp
[INFO] Assembling webapp [atlas-webapp] in 
[/Users/MYSELF/Projects/External/incubator-atlas/webapp/target/atlas-webapp-0.6-incubating-SNAPSHOT]
[INFO] Processing war project
[INFO] Copying webapp webResources 
[/Users/MYSELF/Projects/External/incubator-atlas/webapp/../dashboard/v2/dist] 
to 
[/Users/MYSELF/Projects/External/incubator-atlas/webapp/target/atlas-webapp-0.6-incubating-SNAPSHOT]
[INFO] Copying webapp webResources 
[/Users/MYSELF/Projects/External/incubator-atlas/webapp/src/main/webapp/WEB-INF]
 to 
[/Users/MYSELF/Projects/External/incubator-atlas/webapp/target/atlas-webapp-0.6-incubating-SNAPSHOT]
[INFO] Copying webapp webResources 
[/Users/MYSELF/Projects/External/incubator-atlas/webapp/target/test-classes] to 
[/Users/MYSELF/Projects/External/incubator-atlas/webapp/target/atlas-webapp-0.6-incubating-SNAPSHOT]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] apache-atlas ....................................... SUCCESS [ 46.311 s]
[INFO] Apache Atlas Typesystem ............................ SUCCESS [ 43.109 s]
[INFO] Apache Atlas Client ................................ SUCCESS [ 16.361 s]
[INFO] Apache Atlas Notification .......................... SUCCESS [ 11.229 s]
[INFO] Apache Atlas Repository ............................ SUCCESS [01:03 min]
[INFO] Apache Atlas Web Application ....................... FAILURE [ 24.910 s]
[INFO] Apache Atlas Documentation ......................... SKIPPED
[INFO] Apache Atlas Hive Bridge ........................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:26 min
[INFO] Finished at: 2015-08-20T10:01:33+02:00
[INFO] Final Memory: 133M/670M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-war-plugin:2.4:war (default-war) on project 
atlas-webapp: Execution default-war of goal 
org.apache.maven.plugins:maven-war-plugin:2.4:war failed: basedir 
/Users/MYSELF/Projects/External/incubator-atlas/webapp/target/test-classes does 
not exist -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :atlas-webapp


The test classes were being included in the war so that they would be available 
for the tests.  If the build is done without tests then the classes are not 
compiled and the target/test-classes can't be added to the war (which we don't 
want anyway, I think).  Making the change to not include the test classes in 
the war but make them available to the tests in the jetty-maven-plugin.


Diffs (updated)
-----

  webapp/pom.xml 05721a6 

Diff: https://reviews.apache.org/r/37689/diff/


Testing
-------

mvn clean package -Dmaven.test.skip=true

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] apache-atlas ....................................... SUCCESS [ 39.854 s]
[INFO] Apache Atlas Typesystem ............................ SUCCESS [ 19.094 s]
[INFO] Apache Atlas Client ................................ SUCCESS [  4.793 s]
[INFO] Apache Atlas Notification .......................... SUCCESS [  2.007 s]
[INFO] Apache Atlas Repository ............................ SUCCESS [ 27.416 s]
[INFO] Apache Atlas Web Application ....................... SUCCESS [ 25.948 s]
[INFO] Apache Atlas Documentation ......................... SUCCESS [01:06 min]
[INFO] Apache Atlas Hive Bridge ........................... SUCCESS [  3.765 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:09 min
[INFO] Finished at: 2015-08-21T14:55:53-04:00
[INFO] Final Memory: 182M/2141M
[INFO] ------------------------------------------------------------------------


Also,

mvn clean package

... all tests pass.


Thanks,

Tom Beerbower

Reply via email to